Skip to content

Track unsuccessful IdV password confirmation attempts #6708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 5 commits into from
Aug 9, 2022
Merged

Track unsuccessful IdV password confirmation attempts #6708

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3350511
Track unsuccessful IdV password confirmation attempts
jmhooper Aug 9, 2022
2bea589
changelog: Improvements, Identity Verification, Internal logging for …
jmhooper Aug 9, 2022
e59b2e7
Come one GitLab
jmhooper Aug 9, 2022
1a0fbc7
cleanup
jmhooper Aug 9, 2022
8410648
cleanup
jmhooper Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/controllers/idv/review_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def confirm_idv_phone_confirmed
def confirm_current_password
return if valid_password?

analytics.idv_review_complete(success: false)
flash[:error] = t('idv.errors.incorrect_password')
redirect_to idv_review_url
end
Expand All @@ -46,7 +47,7 @@ def create
init_profile
user_session[:need_personal_key_confirmation] = true
redirect_to next_step
analytics.idv_review_complete
analytics.idv_review_complete(success: true)
analytics.idv_final(success: true)

return unless FeatureManagement.reveal_gpo_code?
Expand Down
11 changes: 9 additions & 2 deletions app/services/analytics_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,8 +962,15 @@ def idv_proofing_resolution_result_missing
end

# User submitted IDV password confirm page
def idv_review_complete
track_event('IdV: review complete')
# @param [Boolean] success
def idv_review_complete(success:, **extra)
track_event(
'IdV: review complete',
{
success: success,
**extra,
}.compact,
Comment thread
jmhooper marked this conversation as resolved.
Outdated
)
end

# User visited IDV password confirm page
Expand Down
12 changes: 11 additions & 1 deletion spec/controllers/idv/review_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,12 +292,19 @@ def show
context 'user fails to supply correct password' do
before do
idv_session.applicant = user_attrs.merge(phone_confirmed_at: Time.zone.now)
stub_analytics
allow(@analytics).to receive(:track_event)
end

it 'redirects to original path' do
put :create, params: { user: { password: 'wrong' } }

expect(response).to redirect_to idv_review_path

expect(@analytics).to have_received(:track_event).with(
'IdV: review complete',
success: false,
)
end
end

Expand All @@ -312,7 +319,10 @@ def show
it 'redirects to personal key path' do
put :create, params: { user: { password: ControllerHelper::VALID_PASSWORD } }

expect(@analytics).to have_received(:track_event).with('IdV: review complete')
expect(@analytics).to have_received(:track_event).with(
'IdV: review complete',
success: true,
)
expect(@analytics).to have_received(:track_event).with(
'IdV: final resolution',
success: true,
Expand Down