Skip to content

Log the enqueued_at date when a user enters a code #6702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 3 commits into from
Aug 8, 2022
Merged

Log the enqueued_at date when a user enters a code #6702

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28099c7
Log the enqueued_at date when a user enters a code
jmhooper Aug 8, 2022
19fc354
changelog: Improvements, Identity Verification, Internal logging for …
jmhooper Aug 8, 2022
ddb4220
fix tests
jmhooper Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/forms/gpo_verify_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ def submit
success: result,
errors: errors,
extra: {
enqueued_at: gpo_confirmation_code&.code_sent_at,
pii_like_keypaths: [[:errors, :otp], [:error_details, :otp]],
pending_in_person_enrollment: pending_in_person_enrollment?,
},
Expand Down
7 changes: 7 additions & 0 deletions spec/forms/gpo_verify_form_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,13 @@
expect(pending_profile.reload).to be_active
end

it 'logs the date the code was sent at' do
result = subject.submit

confirmation_code = pending_profile.gpo_confirmation_codes.last
expect(result.to_h[:enqueued_at]).to eq(confirmation_code.code_sent_at)
end

context 'pending in person enrollment' do
let!(:enrollment) do
create(:in_person_enrollment, :establishing, profile: pending_profile, user: user)
Expand Down