Closed
Conversation
-- What We are saving progress, but still trying to figure out where to inject the faile attempts check in order to trigger manual camera/upload flow.
peggles2
force-pushed
the
parissa-LG6777
branch
from
93e9463 to
3e6ae99
Compare
aduth
reviewed
Aug 9, 2022
Contributor
There was a problem hiding this comment.
While I'm glad to see this converted to TypeScript, what would you think of creating a separate pull request just for that porting (since it's a large changeset), to more easily distinguish the changes for supporting the work of this ticket?
Contributor
There was a problem hiding this comment.
I could certainly do that. Given the actual ticket level things we changed, I will have to update the JSDoc type annotations anyway in several places. But of course those will be smaller changes
-- What For clarity in the FailedCaptureContext interface, we've added a property called `forceNativeCamera` which is a boolean value that will update in the FailedCaptureContextProvider whenever the maxAttemptsBeforeNativeCamera is equal to or exceeds the current failedCaptures value. Additionally, we finally have some working tests for this. For the moment, we only get results by forcing maxAttemptsBeforeNativeCamera to be 0, then clicking the file input. This seems to do the trick. But we need to figure out how to test a couple of other scenarios, and how to force failures from that point in a test case.
changelog: Improvements, Acuant, updating max attempts before login
-- What This commit updates various JSDoc type annotations so that they accurately describe the new structure of the FailedCaptureAttempts context. Specifically, we added maxAttemptsBeforeNativeCamera and forceNativeCamera to this context in previous commits. Now the types and provider components accurately reflect those changes.
eric-gade
force-pushed
the
parissa-LG6777
branch
from
eff670c to
bfe3064
Compare
added 2 commits
August 11, 2022 14:56
-- What Adding a test to ensure that logging is *not* called in the case where failed attempts is not equal or greater to the max attempts before native camera is forced. changelog: Improvements, Acuant Camera settings, updating max failures before native camera is triggered
changelog: Improvements, Acuant native camera, linting fixes
Contributor
|
Looks like this was superseded by #6727. Closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress not ready for review.