Conversation
…ction for pivcac (LG-7020)
mitchellhenke
approved these changes
Aug 2, 2022
zachmargolis
reviewed
Aug 3, 2022
|
|
||
| def index | ||
| @two_factor_options_form = TwoFactorOptionsForm.new(current_user) | ||
| two_factor_options_form |
Contributor
There was a problem hiding this comment.
since two_factor_options_form is a memoized method, we could lazily call it later and still get the same value. Is there a reason to instantiate it here?
This jumps out at me because we're calling the method but not using the result anywhere, so I think we can just remove it
Contributor
Author
There was a problem hiding this comment.
I know we call it out as a global variable to be used in the view later. I guess i can also call it as a helper method.
mdiarra3
deleted the
mdiarra/LG-7020-prevent-user-skipping-adding-authentication-method
branch
mdiarra3
restored the
mdiarra/LG-7020-prevent-user-skipping-adding-authentication-method
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.