Skip to content

LG-7035: Clear in-person proofing session when starting over#6650

Merged
aduth merged 2 commits intomainfrom
aduth-lg-7035-ipp-start-over
Jul 28, 2022
Merged

LG-7035: Clear in-person proofing session when starting over#6650
aduth merged 2 commits intomainfrom
aduth-lg-7035-ipp-start-over

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 28, 2022

Why: So that a user can start over from the beginning and not be skipped past other steps.

**Why**: So that a user can start over from the beginning and not be skipped past other steps.

changelog: Upcoming Features, In-person proofing, Implement "Start Over" for in-person proofing
@aduth aduth requested review from a team and tomas-nava July 28, 2022 16:39
Copy link
Contributor

@NavaTim NavaTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@NavaTim NavaTim self-requested a review July 28, 2022 17:19
@NavaTim
Copy link
Contributor

NavaTim commented Jul 28, 2022

Build failed, though. Could be transient or related to the 2FA change in the tests.

@aduth
Copy link
Contributor Author

aduth commented Jul 28, 2022

Build failed, though. Could be transient or related to the 2FA change in the tests.

I missed a minor change needed for the specs, since I changed it so that the begin_in_person_proofing helper doesn't include the sign-in. This should be fixed in 203f666.

@aduth aduth merged commit 54443ba into main Jul 28, 2022
@aduth aduth deleted the aduth-lg-7035-ipp-start-over branch July 28, 2022 17:55
@solipet solipet mentioned this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants