Skip to content

Initialize IPP pii_from_user with user UUID#6641

Merged
aduth merged 3 commits intomainfrom
aduth-lg-7049-uuid-required
Jul 27, 2022
Merged

Initialize IPP pii_from_user with user UUID#6641
aduth merged 3 commits intomainfrom
aduth-lg-7049-uuid-required

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 27, 2022

Why: Because it's a required attribute for the real resolution vendor implementation, which otherwise fails without it.

**Why**: Because it's a required attribute for the real resolution vendor implementation, which otherwise fails without it.

changelog: Upcoming Features, In-person proofing, Add missing user UUID attribute for proofing jobs
@aduth aduth requested review from a team and svalexander July 27, 2022 17:46
Comment on lines +6 to +16
required_attributes :uuid,
:first_name,
:last_name,
:dob,
:ssn,
:address1,
:city,
:state,
:zipcode

optional_attributes :address2, :uuid_prefix, :dob_year_only
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syncing this to the real vendor implementation should help surface the issue in feature specs.

required_attributes :uuid,
:first_name,
:last_name,
:dob,
:ssn,
:address1,
:city,
:state,
:zipcode
optional_attributes :address2, :uuid_prefix, :dob_year_only

@tomas-nava
Copy link
Contributor

tomas-nava commented Jul 27, 2022

this test is failing on this branch (locally and on GitLab); haven't investigated why yet:

bundle exec rspec spec/features/saml/ial2_sso_spec.rb:143

@aduth
Copy link
Contributor Author

aduth commented Jul 27, 2022

@tomas-nava Taking a look at that one now. The other spec failures for agent_spec.rb are legit, since we weren't fully stubbing an applicant for those. Regardless we may be able to get past it by reverting the changes to the mock client, even if it leaves us without much regression assurances.

@aduth
Copy link
Contributor Author

aduth commented Jul 27, 2022

The issue with ial2_sso_spec turned out to be a real, identical issue impacting another usage of the resolution vendors which also wasn't passing UUID (fixed in 24ed078). It likely hasn't been noticed 'til now since the specific functionality (re-sending a letter after it "bounces") is not enabled in any environment, even local development.

:last_name,
:dob,
:ssn,
:address1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for clarification - address1 is the street address correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we populate it through the Idv::AddressForm (Address step):

ATTRIBUTES = %i[state zipcode city address1 address2].freeze

def consume_params(params)
params.each do |key, value|
raise_invalid_address_parameter_error(key) unless ATTRIBUTES.include?(key.to_sym)
send("#{key}=", value)
if send(key) != @pii[key] && (send(key).present? || @pii[key].present?)
@address_edited = true
end
end
end

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit 9a06c7e into main Jul 27, 2022
@aduth aduth deleted the aduth-lg-7049-uuid-required branch July 27, 2022 19:45
@solipet solipet mentioned this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants