LG_6949 Add AttemptsAPI Logout: SessionsController#6636
Merged
ThatSpaceGuy merged 2 commits intomainfrom Jul 27, 2022
Merged
Conversation
Contributor
|
For completeness sake, we filed LG-7034 to implement this code in LogoutController and SamlIdpController (via SamlIdpLogoutConcern). Putting this in LogoutController got more complicated than we expected so we split the work out. |
ThatSpaceGuy
force-pushed
the
LG-6949--add-test-for-logout
branch
from
3da5e12 to
a7335ad
Compare
changelog: Internal, Attempts API, Track additional events
[skip changelog]
ThatSpaceGuy
force-pushed
the
LG-6949--add-test-for-logout
branch
from
4b4a2c6 to
fd2bab5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IRS Attempts API Logout Event and track the logout event in the Sessions Controller.
[skip changelog]