LG-6992: resolve secure header issues#6625
Merged
mitchellhenke merged 8 commits intomainfrom Jul 27, 2022
Merged
Conversation
mdiarra3
force-pushed
the
LG-6992-allow-redirect-back-safely
branch
from
9f7e4c2 to
c51c911
Compare
mitchellhenke
approved these changes
Jul 25, 2022
zachmargolis
approved these changes
Jul 25, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM. Did something silently fail by not including these mixins? Can we turn that into an error so we catch that earlier?
| require 'rails_helper' | ||
|
|
||
| describe Users::AdditionalMfaRequiredController do | ||
| render_views |
Contributor
There was a problem hiding this comment.
render_views can slow down tests a bunch, is it possible to add this only in certain contexts or certain specs? ex the ones that check for redirects?
mitchellhenke
force-pushed
the
LG-6992-allow-redirect-back-safely
branch
from
0715968 to
c23082f
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 27, 2022
* changelog: Bug Fixes, Authentication, Fix redirect bugs related to regenerating backup codes and add Content Security Policy headers to when user skips adding MFA (LG-6992) Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack thread with original issue: https://gsa-tts.slack.com/archives/C0NGESUN5/p1658765266167019