Skip to content

Jskinner lg5949 analytics events 28#6598

Merged
jskinne3 merged 10 commits intomainfrom
jskinner-lg5949-analytics-events-28
Jul 18, 2022
Merged

Jskinner lg5949 analytics events 28#6598
jskinne3 merged 10 commits intomainfrom
jskinner-lg5949-analytics-events-28

Conversation

@jskinne3
Copy link
Contributor

@jskinne3 jskinne3 commented Jul 18, 2022

LG-5949
https://cm-jira.usa.gov/browse/LG-5949
analytics events number 28, replaces these 5 constants with methods:

  1. BACKUP_CODE_DELETED
  2. BACKUP_CODE_SETUP_VISIT
  3. BACKUP_CODE_SETUP_SUBMITTED
  4. SAML_AUTH
  5. SESSION_TIMED_OUT

Found that numbers 1 and 3 were not used; these were simply removed.

Tested with:

bundle exec rspec spec/controllers/users/backup_code_setup_controller_spec.rb
bundle exec rspec spec/controllers/saml_idp_controller_spec.rb
bundle exec rspec spec/controllers/users/sessions_controller_spec.rb

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jskinne3 jskinne3 merged commit 694e31d into main Jul 18, 2022
@jskinne3 jskinne3 deleted the jskinner-lg5949-analytics-events-28 branch July 18, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants