LG-6625: Hide IPP troubleshooting option for failures#6597
Conversation
**Why**: So that it is available from when response values are checked (e.g. for result type)
Consistency with ApiImageUploadForm, and availability to check if failure type
**Why**: So that the option to proof in person is only extended to those who would be successful in proofing. changelog: Upcoming Features, In-person proofing, Hide troubleshooting option for document capture failure results
| def doc_auth_result_from_uploaded_file | ||
| parsed_data_from_uploaded_file&.[]('doc_auth_result') | ||
| end |
There was a problem hiding this comment.
Our developer docs specify that a YAML test file can include doc_auth_result as a top-level field, but we previously weren't actually passing this along as the extra[:doc_auth_result] value.
changelog: Upcoming features, In-person proofing, Hide IPP troubleshooting option for failures
| submissionError instanceof UploadFormEntriesError | ||
| ? withProps({ | ||
| remainingAttempts: submissionError.remainingAttempts, | ||
| isFailedResult: submissionError.isFailedResult, |
There was a problem hiding this comment.
just want to clarify for myself - is isFailedResult for any id upload failure of for the kind that would not trigger an option for in person proofing (ie barcode can't be read)?
There was a problem hiding this comment.
The way it's being treated here is as a "hard failure", meaning that it's a document which was recognized as unacceptable (fraudulent, etc.). This is one of the results which can be returned from our document authentication vendors. It's also distinct from other non-successful results like "unknown" or "attention". The ticket is making it so that we can continue showing the troubleshooting option for certain unsuccessful results (unknown, attention), but not for failures.
identity-idp/app/services/doc_auth/acuant/result_codes.rb
Lines 8 to 19 in 17d7e30
Why: So that the option to proof in person is only extended to those who would be successful in proofing.
Testing Instructions:
Document Examples:
attention.yml:failed.yml:Screenshots: