Skip to content

Switch from PostCSS/Autoprefixer/CSSNano to Parcel CSS #6591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Aug 5, 2022
Merged

Switch from PostCSS/Autoprefixer/CSSNano to Parcel CSS #6591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions app/javascript/packages/build-sass/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { basename, join } from 'path';
import { writeFile } from 'fs/promises';
import sass from 'sass-embedded';
import postcss from 'postcss';
import autoprefixer from 'autoprefixer';
import cssnano from 'cssnano';
import { transform as parcelTransform, browserslistToTargets } from '@parcel/css';
import browserslist from 'browserslist';

/** @typedef {import('sass-embedded').CompileResult} CompileResult */
/** @typedef {import('sass-embedded').Options<'sync'>} SyncSassOptions */
Expand All @@ -15,14 +14,9 @@ import cssnano from 'cssnano';
* @prop {boolean} optimize Whether to optimize output for production.
*/

/**
* Returns the given array with false values omitted.
*
* @template A
*
* @param {A[]} array
*/
const compact = (array) => /** @type {Array<Exclude<A, false>>} */ (array.filter(Boolean));
const TARGETS = browserslistToTargets(
browserslist(browserslist.loadConfig({ path: process.cwd() })),
);

/**
* Compiles a given Sass file.
Expand All @@ -41,15 +35,20 @@ export async function buildFile(file, options) {
quietDeps: true,
});

const postcssPlugins = compact([autoprefixer, optimize && cssnano]);
const postcssResult = await postcss(postcssPlugins).process(sassResult.css, { from: file });

let outFile = basename(file, '.scss');

const parcelResult = parcelTransform({
filename: outFile,
code: Buffer.from(sassResult.css),
minify: optimize,
targets: TARGETS,
});

if (outDir) {
outFile = join(outDir, outFile);
}

await writeFile(outFile, postcssResult.css);
await writeFile(outFile, parcelResult.code);

return sassResult;
}
5 changes: 2 additions & 3 deletions app/javascript/packages/build-sass/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@
"build-sass": "./cli.js"
},
"dependencies": {
"autoprefixer": "^10.4.4",
"@parcel/css": "^1.12.0",
"browserslist": "^4.21.2",
"chokidar": "^3.5.3",
"cssnano": "^5.1.7",
"postcss": "^8.4.12",
"sass-embedded": "^1.53.0"
}
}
Loading