Skip to content

Update Rails, Octokit gems#6582

Merged
aduth merged 2 commits intomainfrom
aduth-rails-6-1-6
Jul 13, 2022
Merged

Update Rails, Octokit gems#6582
aduth merged 2 commits intomainfrom
aduth-rails-6-1-6

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 13, 2022

Why: To resolve security advisories which are currently causing builds to fail.

Release notes:

I had to be rather tactical with the upgrade, since bundle update rails octokit upgraded a lot of other dependencies which caused some compatibility issues (specifically Zeitwerk 2.6.0 setup warnings and Faraday 2.0.0 removed retry middleware).

Click to see example warnings
08:57:12 web.1         | WARNING: Zeitwerk defines the constant ActiveJob after the directory
08:57:12 web.1         | 
08:57:12 web.1         |     /gems/3.0.0/gems/good_job-2.7.4/lib/active_job
08:57:12 web.1         | 
08:57:12 web.1         | To prevent that, please configure the loader to ignore it:
08:57:12 web.1         | 
08:57:12 web.1         |     loader.ignore("#{__dir__}/active_job")
08:57:12 web.1         | 
08:57:12 web.1         | Otherwise, there is a flag to silence this warning:
08:57:12 web.1         | 
08:57:12 web.1         |     Zeitwerk::Loader.for_gem(warn_on_extra_files: false)
08:57:16 web.1         | To use retry middleware with Faraday v2.0+, install `faraday-retry` gem

Process:

  • bundle update rails
  • bundle update octokit --conservative
  • Manual downgrade zeitwerk in Gemfile.lock from 2.6.0 to 2.5.4

**Why**: To resolve security advisories which are currently causing builds to fail.

changelog: Internal, Security, Update dependencies to resolve security advisories
@mitchellhenke
Copy link
Contributor

For posterity, we don’t serialize any columns as YAML so we shouldn’t be directly vulnerable to this 🙂

@aduth aduth merged commit de7f530 into main Jul 13, 2022
@aduth aduth deleted the aduth-rails-6-1-6 branch July 13, 2022 14:20
mitchellhenke pushed a commit that referenced this pull request Jul 13, 2022
* Update Rails, Octokit gems

**Why**: To resolve security advisories which are currently causing builds to fail.

changelog: Internal, Security, Update dependencies to resolve security advisories

* Expire cookies using public methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants