Conversation
**Why**: To resolve security advisories which are currently causing builds to fail. changelog: Internal, Security, Update dependencies to resolve security advisories
mitchellhenke
approved these changes
Jul 13, 2022
Contributor
|
For posterity, we don’t serialize any columns as YAML so we shouldn’t be directly vulnerable to this 🙂 |
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 13, 2022
* Update Rails, Octokit gems **Why**: To resolve security advisories which are currently causing builds to fail. changelog: Internal, Security, Update dependencies to resolve security advisories * Expire cookies using public methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To resolve security advisories which are currently causing builds to fail.
Release notes:
I had to be rather tactical with the upgrade, since
bundle update rails octokitupgraded a lot of other dependencies which caused some compatibility issues (specifically Zeitwerk 2.6.0 setup warnings and Faraday 2.0.0 removed retry middleware).Click to see example warnings
08:57:12 web.1 | WARNING: Zeitwerk defines the constant ActiveJob after the directory 08:57:12 web.1 | 08:57:12 web.1 | /gems/3.0.0/gems/good_job-2.7.4/lib/active_job 08:57:12 web.1 | 08:57:12 web.1 | To prevent that, please configure the loader to ignore it: 08:57:12 web.1 | 08:57:12 web.1 | loader.ignore("#{__dir__}/active_job") 08:57:12 web.1 | 08:57:12 web.1 | Otherwise, there is a flag to silence this warning: 08:57:12 web.1 | 08:57:12 web.1 | Zeitwerk::Loader.for_gem(warn_on_extra_files: false)Process:
bundle update railsbundle update octokit --conservativezeitwerkinGemfile.lockfrom2.6.0to2.5.4