Skip to content

Fix spec flakiness for non-unique component class name #6571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Jul 11, 2022
Merged

Fix spec flakiness for non-unique component class name #6571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/components/block_link_component_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
end

context 'with custom renderer' do
class ExampleComponent < BaseComponent
class ExampleBlockLinkCustomRendererComponent < BaseComponent
def initialize(href:, **)
@href = href
end
Expand All @@ -43,7 +43,7 @@ def call
it 'renders using the custom renderer' do
rendered = render_inline BlockLinkComponent.new(
url: '/',
action: ExampleComponent.method(:new),
action: ExampleBlockLinkCustomRendererComponent.method(:new),
).with_content('Link Text')

expect(rendered).to have_css('button[data-href="/"]', text: 'Example Link Text')
Expand Down