Add configuration for TOTP authentication interval#6547
Merged
mitchellhenke merged 1 commit intomainfrom Jul 5, 2022
Merged
Conversation
changelog: Internal, Authentication, Explicitly configure TOTP authentication interval
mitchellhenke
deleted the
mitchellhenke/explicitly-configure-totp-interval
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to primarily support the changes in #6545
Our current setting is the default interval of 30 seconds and we do not want to change it (it is also correctly consistent with RFC 6238).
A single TOTP is valid only once in an interval, and the default of 30 seconds does not always work well in tests where we may be logging in multiple times.
This PR adds the configuration to allow setting the interval and explicitly sets the interval to the configured value.