LG-6202: Collapse excess line break for single-line address#6386
Merged
Conversation
**Why**: To match the existing screen. changelog: Upcoming Features, Identity Verification, Add password confirmation step
zachmargolis
approved these changes
May 19, 2022
|
|
||
| rerender(<PersonalInfoSummary pii={{ ...DEFAULT_PII, address2: 'PO BOX 1' }} />); | ||
|
|
||
| address = getByText('1 FAKE RDPO BOX 1GREAT FALLS, MT 59010'); |
Contributor
There was a problem hiding this comment.
it's super weird to see the <br /> get hidden so the lines run together :/
Contributor
Author
There was a problem hiding this comment.
Yeah this was a bit clumsy for me to put together, especially since I didn't realize we previously had an extra space in there as well. After removing that, it makes a bit more sense that the text content is the individual text nodes, joined together with no joiner.
There are some extra options for matching text (getByText((text) => ...), getByText('text', { normalizer: ... })), which could maybe be helpful for this. Or querying the individual slices of text and asserting against its sibling content (e.g. getByText('1 FAKE RD').nextElementSibling.nodeName === 'BR')).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To match the existing screen.