Conversation
stevegsa
changed the title
…verification failures report
Comment on lines
+77
to
+80
| csv = CSV.parse(reports[0]) | ||
| expect(csv.length).to eq(2) | ||
| expect(csv.first).to eq(['uuid', 'welcome_view_at', 'error_code']) | ||
| expect(csv[1]).to eq([uuid, now.to_time.utc.iso8601, 'DOCUMENT_FAIL']) |
Contributor
There was a problem hiding this comment.
If we parse the CSV with headers: true we can get some nice fields to check:
Suggested change
| csv = CSV.parse(reports[0]) | |
| expect(csv.length).to eq(2) | |
| expect(csv.first).to eq(['uuid', 'welcome_view_at', 'error_code']) | |
| expect(csv[1]).to eq([uuid, now.to_time.utc.iso8601, 'DOCUMENT_FAIL']) | |
| csv = CSV.parse(reports.first, headers: true) | |
| expect(csv.length).to eq(1) | |
| expect(csv.first['uuid']).to eq(uuid) | |
| expect(csv.first['welcome_view_at']).to eq(now.to_time.utc.iso8601) | |
| expect(csv.first['error_code']).to eq('DOCUMENT_FAIL') |
…verification failures report
stevegsa
deleted the
stevegsa-add-more-doc-failures-to-verification-failures-reports.rb
branch
aduth
reviewed
May 23, 2022
| t.integer "verify_phone_submit_count", default: 0 | ||
| t.datetime "verify_phone_submit_at" | ||
| t.datetime "document_capture_submit_at" | ||
| t.index ["issuer"], name: "index_doc_auth_logs_on_issuer" |
Contributor
There was a problem hiding this comment.
Was it intended to remove this line? When running the migration locally, the line was added back.
aduth
added a commit
that referenced
this pull request
May 24, 2022
**Why**: So that there aren't local changes after a developer runs migrations. Context: #6382 (comment) [skip changelog]
Merged
aduth
added a commit
that referenced
this pull request
May 25, 2022
**Why**: So that there aren't local changes after a developer runs migrations. Context: #6382 (comment) [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Right now DOCUMENT_FAIL conditions are triggered when the entire image set is rejected by the back end vendor. We are going to add to that users that at least attempted to submit a back image to make it behave more like the drop offs report. Technically they will not be the same because the drop offs report just looks at counts and a welcome timestamp in range (so technically it's reporting the furthest the user ever got) and not the daily errors. I'm also adding in a little buffer to allow for users that submit for the day but then restart the process either within the same session or within the buffer of 23 hours since the report currently runs every 24 hours. (ie welcome step will actually have a greater timestamp then the failed submit). Also renaming the report verification-failures-report and putting all the vendor reports in one directory.
How: Add timestamps for last back image submits for mobile, desktop, hybrid.