LG-6220: Add password confirm text content (IdV app)#6371
Merged
Conversation
For external, new-tab link behavior required in password confirm step
Collapse extra div
**Why**: For parity with the existing screen, we should include all existing content which explains the reason for the user to enter their password. changelog: Upcoming Features, Identity Verification, Add password confirmation step
**Why**: Avoid duplicated logic
|
As a concerned citizen, for no reason at all...I've got my eye on you, @aduth! 👁️ I took a sec to try to find something to nitpick you on but then I realized I've got other PRs I actually need to review. 😝 |
Contributor
Author
As if there are any mistakes here to be nitpicked! 😆 (Good to hear from you, Alex! I knew you missed me) |
I told you I'd harass you in a PR at some point when you least expected it. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: For parity with the existing screen, we should include all existing content which explains the reason for the user to enter their password.
Testing Instructions:
You will need to set the step as enabled in your local
config/application.yml:Screenshots: