Skip to content

Revise IdV app alert content to static content#6370

Merged
aduth merged 3 commits intomainfrom
aduth-verify-flow-status-2
May 20, 2022
Merged

Revise IdV app alert content to static content#6370
aduth merged 3 commits intomainfrom
aduth-verify-flow-status-2

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented May 18, 2022

Why: Avoid extra complexity around dealing with edge cases with alerts (e.g. warning subpages like with "Forgot Password" screen).

The previous implementation was also done in anticipation that we may need to omit status messages from step reuse such as personal key reset via account dashboard. We can sort through this when the time comes, but it's likely we could control this with either context or a prop of the step component.

Testing Instructions:

You will need to set the step as enabled in your local config/application.yml:

development:
  idv_api_enabled_steps: '["password_confirm","personal_key","personal_key_confirm"]'
  1. Navigate to http://localhost:3000
  2. Sign in
  3. Navigate to http://localhost:3000/verify
  4. Complete proofing flow up to password confirmation step
  5. Observe success alert "We found records matching your Phone of record"
  6. Click "Follow these instructions" (adjacent "Forgot your password?")
  7. Observe that the success alert is no longer visible

Screenshot:

Before After
Screen Shot 2022-05-18 at 8 55 27 AM Screen Shot 2022-05-18 at 8 55 41 AM

@aduth aduth requested a review from a team May 18, 2022 12:58
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aduth added 3 commits May 19, 2022 15:10
**Why**: So that specs which render components using it (namely ClipboardButtonElement) don't need to rely on other specs to set up the polyfill to pass in isolation.
**Why**: Avoid extra complexity around dealing with edge cases with alerts (e.g. warning subpages like with "Forgot Password" screen)
changelog: Upcoming Features, Identity Verification, Add password confirmation step
@aduth aduth force-pushed the aduth-verify-flow-status-2 branch from 911f28d to 0bf637c Compare May 19, 2022 19:10
@aduth aduth merged commit ad93bf4 into main May 20, 2022
@aduth aduth deleted the aduth-verify-flow-status-2 branch May 20, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants