Revise IdV app alert content to static content#6370
Merged
Conversation
**Why**: So that specs which render components using it (namely ClipboardButtonElement) don't need to rely on other specs to set up the polyfill to pass in isolation.
**Why**: Avoid extra complexity around dealing with edge cases with alerts (e.g. warning subpages like with "Forgot Password" screen)
changelog: Upcoming Features, Identity Verification, Add password confirmation step
911f28d to
0bf637c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Avoid extra complexity around dealing with edge cases with alerts (e.g. warning subpages like with "Forgot Password" screen).
The previous implementation was also done in anticipation that we may need to omit status messages from step reuse such as personal key reset via account dashboard. We can sort through this when the time comes, but it's likely we could control this with either context or a prop of the step component.
Testing Instructions:
You will need to set the step as enabled in your local
config/application.yml:Screenshot: