Add tracking of billable IAL to SP Redirect events#6369
Merged
Conversation
jmhooper
reviewed
May 18, 2022
orenyk
force-pushed
the
oyk-redirect-ial-logging
branch
from
fc5e3a4 to
c86e761
Compare
**Why:** With the introduction of IALMAX to SAML using the Comparison attribute, it is now impossible to filter "SP Redirect Initiated" log events by the actual IAL that was sent back, since the IALContext returns an IAL of zero by default. This change adds an additional attribute to SP Redirect Initiated events for SAML and OIDC requests to track the actual billable IAL (based on whether or not the user has proofed). This also adds some more comprehensive controller specs for IALMAX behavior for OIDC. changelog: Improvements, Authentication, Track billable "IAL" in the event log for successful requests
orenyk
force-pushed
the
oyk-redirect-ial-logging
branch
from
c86e761 to
e64fa1b
Compare
orenyk
commented
May 19, 2022
|
|
||
| IdentityLinker.new(user, service_provider).link_identity(ial: 2) | ||
| user.identities.last.update!( | ||
| verified_attributes: %w[given_name family_name birthdate verified_at], |
Contributor
Author
There was a problem hiding this comment.
note that these should not all be required but there's a bug with OIDC and IALMAX: https://cm-jira.usa.gov/browse/LG-6355
jmhooper
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: With the introduction of IALMAX to SAML using the Comparison
attribute, it is now impossible to filter "SP Redirect Initiated" log
events by the actual IAL that was sent back, since the IALContext
returns an IAL of zero by default. This change adds an additional
attribute to SP Redirect Initiated events for SAML and OIDC requests to
track the actual billable IAL (based on whether or not the user has
proofed). This also adds some more comprehensive controller specs for
IALMAX behavior for OIDC.
changelog: Improvements, Authentication, Track billable "IAL" in the event log for successful requests