Document analytics events, batch 18 (LG-5937)#6368
Merged
zachmargolis merged 12 commits intomainfrom May 18, 2022
Merged
Conversation
Migrate analytics events (LG-5937) changelog: Internal, Documentation, Document additional analytics events
stevegsa
reviewed
May 18, 2022
| analytics.track_event( | ||
| Analytics::MULTI_FACTOR_AUTH_ENTER_PERSONAL_KEY_VISIT, context: context | ||
| ) | ||
| analytics.multi_factor_auth_enter_totp_visit(context: context) |
Contributor
There was a problem hiding this comment.
multi_factor_auth_enter_personal_key_visit
Contributor
Author
There was a problem hiding this comment.
whoops, great catch, thanks
tomas-nava
reviewed
May 18, 2022
spec/controllers/two_factor_authentication/personal_key_verification_controller_spec.rb
Outdated
Show resolved
Hide resolved
…cation_controller_spec.rb Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
stevegsa
approved these changes
May 18, 2022
aduth
reviewed
Jun 24, 2022
| return unless FeatureManagement.prefill_otp_codes? | ||
| @code = ROTP::TOTP.new(current_user.auth_app_configurations.first.otp_secret_key).now | ||
| analytics.track_event(Analytics::MULTI_FACTOR_AUTH_ENTER_TOTP_VISIT) | ||
| analytics.multi_factor_auth_enter_totp_visit |
Contributor
There was a problem hiding this comment.
context is a required parameter for multi_factor_auth_enter_totp_visit, so this errors.
ArgumentError at /login/two_factor/authenticator
missing keyword: :context
Fortunately, this code is guarded by FeatureManagement.prefill_otp_codes?, so it's really only an issue in local development.
Contributor
There was a problem hiding this comment.
Although... now that I think of it, we probably want to be logging this event in all cases, not only prefill_otp_codes? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it says on the tin.
In this batch: