Skip to content

LG-6120 update alt text#6364

Merged
nprimak merged 5 commits intomainfrom
nprimak/lg-6130-update-alt-text
May 18, 2022
Merged

LG-6120 update alt text#6364
nprimak merged 5 commits intomainfrom
nprimak/lg-6130-update-alt-text

Conversation

@nprimak
Copy link
Contributor

@nprimak nprimak commented May 17, 2022

LG-6120

What
This is the last and final subtask of LG-5774, reviewing images with empty alt tags to check if they are decorative or informative. This Figma link includes the images which were reviewed, and this translation doc includes which words were added to the yml locale files.

Testing Instructions

  1. Go to localhost:3000/verify and create an account
  2. While following through the steps, look out for the images in the Figma file listed as Informative
  3. For those listed as informative (as you come across them), you can inspect the image with developer tools to see if the expected value shows up in the alt tag.

Copying @Danielle-Lee for content and @Kamal-Munshi for design on this PR for visibility and/or questions.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines 53 to 56
bullet_1_img: Email
bullet_1_html: An <strong>email address</strong>.
bullet_2_img: Device
bullet_2_html: Enable <strong>two-step authentication</strong>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine here since we're following an established pattern, but if we were to do the original implementation over again, I think it'd be nicer and more maintainable to structure these bullets as an array (easier to add and remove).

e.g.

start: 
  bullets: 
    - image: Email
      html: An <strong>email address</strong>
    - image: Device
      html: Enable <strong>two-step authentication</strong>.

nprimak added 2 commits May 17, 2022 17:46
changelog: Accessibility, Alt Tags, updating empty alt tags (LG-6120)
@nprimak nprimak merged commit facd49d into main May 18, 2022
@nprimak nprimak deleted the nprimak/lg-6130-update-alt-text branch May 18, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants