Conversation
aduth
approved these changes
May 17, 2022
config/locales/devise/en.yml
Outdated
Comment on lines
53
to
56
| bullet_1_img: Email | ||
| bullet_1_html: An <strong>email address</strong>. | ||
| bullet_2_img: Device | ||
| bullet_2_html: Enable <strong>two-step authentication</strong>. |
Contributor
There was a problem hiding this comment.
I think it's fine here since we're following an established pattern, but if we were to do the original implementation over again, I think it'd be nicer and more maintainable to structure these bullets as an array (easier to add and remove).
e.g.
start:
bullets:
- image: Email
html: An <strong>email address</strong>
- image: Device
html: Enable <strong>two-step authentication</strong>.changelog: Accessibility, Alt Tags, updating empty alt tags (LG-6120)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LG-6120
What
This is the last and final subtask of LG-5774, reviewing images with empty alt tags to check if they are decorative or informative. This Figma link includes the images which were reviewed, and this translation doc includes which words were added to the yml locale files.
Testing Instructions
Copying @Danielle-Lee for content and @Kamal-Munshi for design on this PR for visibility and/or questions.