Remove unnecessary or outdated i18n-tasks unused keys#6361
Merged
Conversation
**Why**: - So that the list is an accurate reflection of used keys - So that all translation data is expected to be used in the application - To minimize use of this override in favor of inline configuration changelog: Internal, Code Quality, Remove unused translation data
aduth
commented
May 17, 2022
mitchellhenke
approved these changes
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The general approach here was to comment out the configuration, running
i18n-tasksand adding back only the keys confirmed to be in use.Since some translations are referenced dynamically (typically why one would use this configuration), I'd appreciate a second set of eyes that the removed translation strings are actually unused.