i18n: Detect array keys for Webpack string extraction#6359
Merged
Conversation
aduth
commented
May 16, 2022
app/javascript/packages/rails-i18n-webpack-plugin/extract-keys-webpack-plugin.js
Outdated
Show resolved
Hide resolved
**Why**: In order for array key support implemented in #6328 to appear as translated, the keys must be extracted, which means we need additional support in the Webpack plugin to detect and extract array keys. changelog: Internal, Localization, Improve browser localization to support array of messages
This previously wasn't able to use array syntax because string extraction wasn't implemented, and now it is
aduth
force-pushed
the
aduth-i18n-array-keys-extraction
branch
from
8a01213 to
27c7e1a
Compare
zachmargolis
approved these changes
May 19, 2022
| * @type {RegExp} | ||
| */ | ||
| const TRANSLATE_CALL = /(?:^|[^\w'-])(?:I18n\.)?t\)?\(\s*['"](.+?)['"][,\s)]/g; | ||
| const TRANSLATE_CALL = /(?:^|[^\w'-])t\)?\(\[?(['"][a-z\d\s_.,'"]+['"])]?[,\s)]/g; |
Contributor
There was a problem hiding this comment.
I hope we can continue to use regexes for this and don't have to get into parser/lexer/AST land lol
Contributor
Author
There was a problem hiding this comment.
Good luck to whoever has to try to interpret this regex in the future! (My future self included) 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: In order for array key support implemented in #6328 to appear as translated, the keys must be extracted, which means we need additional support in the Webpack plugin to detect and extract array keys.
Related: #6323 (comment)