Drop state_id from session SENSITIVE_REGEX#6354
Merged
mitchellhenke merged 1 commit intomainfrom May 16, 2022
Merged
Conversation
[skip changelog]
mitchellhenke
requested review from
jc-gsa,
jmhooper,
mdiarra3,
orenyk and
zachmargolis
Contributor
|
Alternatively, could we change the mock value to something more unique? |
aduth
approved these changes
May 16, 2022
Contributor
Author
We could, yeah. I am a bit skeptical of the value of the approach where we check against mock values since the session ends up holding a lot of different things from different sources. The odds of a false positive aren't as low as I'd like. |
mitchellhenke
deleted the
mitchellhenke/drop-state-id-number-from-sensitive
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #6315. This PR drops
:state_id_number, which is1111111111111because it generated a false positive match.