IdV app: Add alert message for password confirmation step#6348
Merged
Conversation
**Why**: For feature parity with the existing password confirmation step, we should show a success alert message for users who have just confirmed their address by phone verification. changelog: Upcoming Features, Identity Verification, Add password confirmation step
|
Hello 18F Identity Developers,
I would like to unsubscribe to this email. Please remove
***@***.*** from this list.
Thank you.
Hung Nguyen
…On Fri, May 13, 2022 at 11:41 AM Andrew Duthie ***@***.***> wrote:
*Why*: For feature parity with the existing password confirmation step,
we should show a success alert message for users who have just confirmed
their address by phone verification.
*Screenshot:*
Before After
[image: localhost_3000_verify_v2_password_confirm (1)]
<https://user-images.githubusercontent.com/1779930/168318986-e3a47016-3f74-4e9d-9174-873ba2c5c021.png> [image:
localhost_3000_verify_v2_password_confirm]
<https://user-images.githubusercontent.com/1779930/168318987-2ccac8e8-999e-4de5-a6b3-37e6ccd8341a.png>
------------------------------
You can view, comment on, or merge this pull request online at:
#6348
Commit Summary
- 772735c
<772735c>
IdV app: Add alert message for password confirmation step
File Changes
(3 files <https://github.com/18F/identity-idp/pull/6348/files>)
- *M* app/javascript/packages/verify-flow/verify-flow-alert.spec.tsx
<https://github.com/18F/identity-idp/pull/6348/files#diff-6e1f62eab93f78ee7310a247aa3c14d35863674e99a5346321f2f612f6d4d994>
(46)
- *M* app/javascript/packages/verify-flow/verify-flow-alert.tsx
<https://github.com/18F/identity-idp/pull/6348/files#diff-1815a29ac208aa9c572bc6dbb66e625b29aa0d36bac109e6253c5a21f0f4c0f3>
(27)
- *M* app/javascript/packages/verify-flow/verify-flow.tsx
<https://github.com/18F/identity-idp/pull/6348/files#diff-5f67d5a3df158f94f44fa0ac9c1775c8811ff5c3a827cd482001a94636fe0802>
(10)
Patch Links:
- https://github.com/18F/identity-idp/pull/6348.patch
- https://github.com/18F/identity-idp/pull/6348.diff
—
Reply to this email directly, view it on GitHub
<#6348>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHSZF42MYHMPG2QIN5OO3DVJZZ2JANCNFSM5V3YKWHQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Hung Nguyen
*Information Services*
*O (301)837-2006*
*8601 Adelphi Road #4503*
*College Park, MD 20740*
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: For feature parity with the existing password confirmation step, we should show a success alert message for users who have just confirmed their address by phone verification.
Testing Instructions:
You will need to set the step as enabled in your local
config/application.yml:Screenshot: