Skip to content

LG-6291: Add password field with toggled visibility to IdV app password confirmation#6341

Merged
aduth merged 7 commits intomainfrom
aduth-lg-6291-password-toggle
May 13, 2022
Merged

LG-6291: Add password field with toggled visibility to IdV app password confirmation#6341
aduth merged 7 commits intomainfrom
aduth-lg-6291-password-toggle

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented May 12, 2022

Why: For feature parity with the existing proofing experience, the user should have the option to toggle visibility of the password field when at the password confirmation step.

Testing Instructions:

You will need to set the step as enabled in your local config/application.yml:

development:
  idv_api_enabled_steps: '["password_confirm","personal_key","personal_key_confirm"]'
  1. Navigate to http://localhost:3000
  2. Sign in
  3. Navigate to http://localhost:3000/verify
  4. Complete proofing flow up to password confirmation step
  5. Enter password
  6. Observe password text is hidden by default
  7. Toggle "Show password"
  8. Observe password text is visible

Screenshots:

Toggled Hidden Toggled Visible
Screen Shot 2022-05-12 at 10 18 42 AM Screen Shot 2022-05-12 at 10 18 38 AM

@aduth aduth requested a review from a team May 12, 2022 14:23
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on the branch and works as expected.

aduth added 7 commits May 13, 2022 10:15
Because soon it will include React component in addition to the custom element
**Why**: So we can have multiple exports
Convention, availability to React component
To be used by PasswordToggle component
To be used by password confirm step
**Why**: For feature parity with the existing proofing experience, the user should have the option to toggle visibility of the password field when at the password confirmation step.

changelog: Upcoming Features, Identity Verification, Add password confirmation step
@aduth aduth force-pushed the aduth-lg-6291-password-toggle branch from e352c8e to fa66c72 Compare May 13, 2022 14:16
@aduth aduth merged commit 7e51b93 into main May 13, 2022
@aduth aduth deleted the aduth-lg-6291-password-toggle branch May 13, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants