LG-6291: Add password field with toggled visibility to IdV app password confirmation#6341
Merged
LG-6291: Add password field with toggled visibility to IdV app password confirmation#6341
Conversation
solipet
approved these changes
May 12, 2022
Contributor
solipet
left a comment
There was a problem hiding this comment.
LGTM. Tested on the branch and works as expected.
Because soon it will include React component in addition to the custom element
**Why**: So we can have multiple exports
Convention, availability to React component
To be used by PasswordToggle component
To be used by password confirm step
**Why**: For feature parity with the existing proofing experience, the user should have the option to toggle visibility of the password field when at the password confirmation step. changelog: Upcoming Features, Identity Verification, Add password confirmation step
Easier searchability
e352c8e to
fa66c72
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: For feature parity with the existing proofing experience, the user should have the option to toggle visibility of the password field when at the password confirmation step.
Testing Instructions:
You will need to set the step as enabled in your local
config/application.yml:Screenshots: