Support non-input element ref assignment for FormSteps#6340
Merged
Conversation
More elegant stubbing cleanup
Because it currently fails!
**Why**: Since not all "fields" will be associated with an input element, as is the case in the desktop strict liveness selfie capture step. [skip changelog]
lint
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression of #6222
Why: Since not all "fields" will be associated with an input element, as is the case in the desktop strict liveness selfie capture step.
This resolves an issue where it is not possible to continue identity proofing for the unshipped, disabled strict liveness step of document capture.
Steps to reproduce:
Before: Nothing happened. Error in console "TypeError: o.checkValidity is not a function".
After: Form submits.
Relevant code:
identity-idp/app/javascript/packages/document-capture/components/selfie-capture.jsx
Line 45 in f25da61