Add feature flag for including SLO in SAML metadata#6330
Merged
Conversation
**Why:** We require logout requests to be signed but not all SAML clients send signed logout requests by default. Turning this on caused certain SAML clients that weren't previously sending SLO requests to us to start sending SLO requests, so this allows us to ease into this. [skip changelog]
jmhooper
approved these changes
May 11, 2022
mdiarra3
pushed a commit
that referenced
this pull request
May 11, 2022
**Why:** We require logout requests to be signed but not all SAML clients send signed logout requests by default. Turning this on caused certain SAML clients that weren't previously sending SLO requests to us to start sending SLO requests, so this allows us to ease into this. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: We require logout requests to be signed but not all SAML
clients send signed logout requests by default. Turning this on caused
certain SAML clients that weren't previously sending SLO requests to us
to start sending SLO requests, so this allows us to ease into this.
[skip changelog]