Skip to content

Regenerate personal key for users with malformed recovery data (LG-6067)#6329

Merged
zachmargolis merged 6 commits intomainfrom
margolis-incorrect-personal-keys
May 11, 2022
Merged

Regenerate personal key for users with malformed recovery data (LG-6067)#6329
zachmargolis merged 6 commits intomainfrom
margolis-incorrect-personal-keys

Conversation

@zachmargolis
Copy link
Contributor

@zachmargolis zachmargolis commented May 10, 2022 •
edited
Loading

  • The UI for this is re-used from Fix Broken Personal Keys (LG-5525) #6010, take a look for the flow
  • This adds a new scenario where about ~70 users have poorly encrypted data in production, the migration flow will be the same

@zachmargolis zachmargolis requested review from a team and mitchellhenke May 10, 2022 22:21
mitchellhenke
mitchellhenke approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@mitchellhenke mitchellhenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 👍🏼

@zachmargolis zachmargolis changed the title Regenrate personal key for users with malformed recovery data (LG-6067) Regenerate personal key for users with malformed recovery data (LG-6067) May 11, 2022
stevegsa
stevegsa approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zachmargolis zachmargolis merged commit ceab799 into main May 11, 2022
@zachmargolis zachmargolis deleted the margolis-incorrect-personal-keys branch May 11, 2022 17:58
@zachmargolis zachmargolis mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchellhenke mitchellhenke mitchellhenke approved these changes

+1 more reviewer

@stevegsa stevegsa stevegsa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zachmargolis @mitchellhenke @stevegsa