-
Notifications
You must be signed in to change notification settings - Fork 166
i18n: Support array of string values in JavaScript implementation #6328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| # `@18f/identity-i18n` | ||
|
|
||
| JavaScript implementation of a Rails-like localization utility. | ||
|
|
||
| When paired with [`@18f/identity-rails-i18n-webpack-plugin`](https://github.com/18F/identity-idp/tree/main/app/javascript/packages/rails-i18n-webpack-plugin), it provides a seamless localization experience to retrieve locale data from [Rails locale data](https://github.com/18F/identity-idp/tree/main/config/locales). | ||
|
|
||
| ## Usage | ||
|
|
||
| Usage should provide a behavior similar to [Rails Internationalization](https://guides.rubyonrails.org/i18n.html), where a given key would be expected to match locale data based on the folder structure found in `config/locales`. | ||
|
|
||
| For example, a key of `foo.bar.baz`, would match the file at `config/locales/foo/en.yml` (for English locales), whose content includes... | ||
|
|
||
| ```yml | ||
| en: | ||
| foo: | ||
| bar: | ||
| baz: Message | ||
| ``` | ||
|
|
||
| ### Basic | ||
|
|
||
| Call the translate function with a key to retrieve the translated message. | ||
|
|
||
| ```yml | ||
| # config/locales/messages/en.yml | ||
| en: | ||
| messages: | ||
| greeting: Hello world! | ||
| ``` | ||
|
|
||
| ```ts | ||
| import { t } from '@18f/identity-i18n'; | ||
|
|
||
| t('messages.greeting'); | ||
| // "Hello world!" | ||
| ``` | ||
|
|
||
| ### Interpolation | ||
|
|
||
| Include an object of variables to interpolate those values in the matched entry. | ||
|
|
||
| ```yml | ||
| # config/locales/messages/en.yml | ||
| en: | ||
| messages: | ||
| greeting: Hello %{recipient}! | ||
| ``` | ||
|
|
||
| ```ts | ||
| import { t } from '@18f/identity-i18n'; | ||
|
|
||
| t('messages.greeting', { recipient: 'world' }); | ||
| // "Hello world!" | ||
| ``` | ||
|
|
||
| ### Pluralization | ||
|
|
||
| An entry which is an object including `one` or `other` keys will automatically choose the correct message based on the `count` variable. | ||
|
|
||
| ```yml | ||
| # config/locales/messages/en.yml | ||
| en: | ||
| messages: | ||
| greeting: | ||
| one: Hello to you! | ||
| other: Hello to all! | ||
| ``` | ||
|
|
||
| ```ts | ||
| import { t } from '@18f/identity-i18n'; | ||
|
|
||
| t('messages.greeting', { count: 1 }); | ||
| // "Hello to you!" | ||
|
|
||
| t('messages.greeting', { count: 2 }); | ||
| // "Hello to all!" | ||
| ``` | ||
|
|
||
| ### Array Values | ||
|
|
||
| An entry may be a single string or an array of strings. Passing an array of key(s) will return an array of messages. | ||
|
|
||
| ```yml | ||
| # config/locales/messages/en.yml | ||
| en: | ||
| messages: | ||
| greetings: | ||
| - Hello! | ||
| - Howdy! | ||
| ``` | ||
|
|
||
| ```ts | ||
| import { t } from '@18f/identity-i18n'; | ||
|
|
||
| t(['messages.greetings']); | ||
| // ["Hello!", "Howdy!"] | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, in case it raises eyebrows: The reason for the identity map is mostly to ensure that, when type-checked, TypeScript takes no issue with the fact that the return value would be expected to be an array, as an assurance of the contract that, when given an array of keys, the return value should be an array of messages.