Fix 500 when trying to display invalid phone numbers#6319
Merged
mitchellhenke merged 2 commits intomainfrom May 6, 2022
Merged
Fix 500 when trying to display invalid phone numbers#6319mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
added 2 commits
May 6, 2022 11:52
changelog: Bug Fixes, Authentication, Fix 500 when phone ID is invalid
mitchellhenke
pushed a commit
that referenced
this pull request
May 6, 2022
* add failing specs * Do not attempt to display phone if it is invalid changelog: Bug Fixes, Authentication, Fix 500 when phone ID is invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect this is limited to people manually editing the form to specify a different (invalid) ID, but it caused some 500s (NR)
This PR adds validation and additional tests around this case. I'm not overly worried about getting the redirect exactly right in case where we redirect back to the homepage. The user in question could be signing up or authenticating, but either way something funky is going on 🙂