Migrate analytics events, batch 14 (LG-5932)#6308
Merged
zachmargolis merged 8 commits intomainfrom May 4, 2022
Merged
Conversation
changelog: Internal, Documentation, Document additional analytics events
stevegsa
approved these changes
May 4, 2022
Contributor
stevegsa
left a comment
stevegsa
left a comment
There was a problem hiding this comment.
Looks good except the failed spec. I'm wishing we kept the CONSTS
Contributor
Author
Turns out the backtrace was not very useful on that one... had nothing to do with the constants, I just typo'd a method name and accidentally called |
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
* Migrate IDV_PHONE_CONFIRMATION_OTP_RATE_LIMIT_ATTEMPTS * Migrate IDV_PHONE_CONFIRMATION_OTP_RATE_LIMIT_LOCKED_OUT * Migrate IDV_PHONE_CONFIRMATION_OTP_RATE_LIMIT_SENDS * Migrate IDV_PHONE_CONFIRMATION_OTP_RESENT * Migrate IDV_PHONE_CONFIRMATION_OTP_SENT changelog: Internal, Documentation, Document additional analytics events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the follow events: