LG-6139: Implement submission form for password confirmation step#6305
Merged
LG-6139: Implement submission form for password confirmation step#6305
Conversation
aduth
force-pushed
the
aduth-password-confirm-submit
branch
2 times, most recently
from
4bb929f to
e2bc7ff
Compare
So we can use requestIdleCallback confidently
So that route name aligns to the submitted step
changelog: Upcoming Features, Identity Verification, Add password confirmation step
aduth
force-pushed
the
aduth-password-confirm-submit
branch
from
e2bc7ff to
dfe2b90
Compare
aduth
commented
May 9, 2022
**Why**: Safari does not support requestIdleCallback, and currently we only load the polyfill module for Internet Explorer
aduth
changed the title
zachmargolis
approved these changes
May 10, 2022
app/javascript/packages/verify-flow/context/secrets-context.tsx
Outdated
Show resolved
Hide resolved
Require URL, JSON, CSRF parameters See: #6305 (comment)
typeof checks are safe if variable is not declared See: #6305 (comment)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that a user can proceed from the password confirmation step to the personal key step.
Testing Instructions:
You'll need to override
idv_api_enabled_stepsin your localapplication.ymlto enable the new step:/verify/v2/password_confirmScreen recording:
password-confirm.mov