Patch: analytics events 11#6303
Merged
zachmargolis merged 3 commits intoLG-5929-document-analytics-11from May 4, 2022
Merged
Conversation
- As of #6294, having it will cause build breakage since it's an unknown tag
gsa-manish
approved these changes
May 4, 2022
Contributor
gsa-manish
left a comment
gsa-manish
left a comment
There was a problem hiding this comment.
Thx for taking care of removing event_name tags.
gsa-manish
added a commit
that referenced
this pull request
May 5, 2022
* LG-5929-document-analytics-11 * Patch: analytics events 11 (#6303) * Remove @identity.idp.event_name - As of #6294, having it will cause build breakage since it's an unknown tag * Remove blank lines * Add clearer comments for each event Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
* LG-5929-document-analytics-11 * Patch: analytics events 11 (#6303) * Remove @identity.idp.event_name - As of #6294, having it will cause build breakage since it's an unknown tag * Remove blank lines * Add clearer comments for each event Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have some additional review feedback for #6293 but it seemed easier to just make this PR instead of leave a bunch more comments
See commits for reasoning, the most important is d1961a1 because once the changes land on
mainthey would break without it