Merged
Conversation
**Why**: Because it's redundant with logging via FrontendLogController and presumably runs up our bill. changelog: Improvements, Analytics, Reduce redundant analytics logging
**Why**: For improved usability, and for alignment with other event tracking methods
mitchellhenke
approved these changes
May 4, 2022
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
* Remove NewRelic frontend event logging **Why**: Because it's redundant with logging via FrontendLogController and presumably runs up our bill. changelog: Improvements, Analytics, Reduce redundant analytics logging * Simplify addPageAction signature **Why**: For improved usability, and for alignment with other event tracking methods * Fix type signature for addPageAction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
For follow-up:
addPageActiontotrackEventaddPageActionReact context altogether, in favor of direct calls totrackEvent