Conversation
**Why**: For better organization, and so that it's accessible to package specs.
Since it's the most common method called, and to allow it to be stored as a reference and called later
Much more convenient
changelog: Internal, Automated Testing, Add test helper for JavaScript stubbing sandbox
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
* Move useSandbox to test-helpers package **Why**: For better organization, and so that it's accessible to package specs. * Add support for destructured sandbox clock * Special-case clock tick destructure proxy Since it's the most common method called, and to allow it to be stored as a reference and called later * Convert existing package spec sandboxes to use test helper Much more convenient * Create passthrough proxy for clock implementation * Add basic spec for clean-up behavior * Add changelog changelog: Internal, Automated Testing, Add test helper for JavaScript stubbing sandbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
spec, but isn't currently accessible to package specsuserEvent.setup({ advanceTimers: clock.tick })