Fix 500 in analytics logging from missing constant#6300
Merged
Conversation
**Why**: So that the build passes, and so that we don't have 500 errors. Context: https://github.com/18F/identity-idp/pull/6288/files#r864759689 [skip changelog]
mitchellhenke
approved these changes
May 4, 2022
mitchellhenke
pushed a commit
that referenced
this pull request
May 4, 2022
**Why**: So that the build passes, and so that we don't have 500 errors. Context: https://github.com/18F/identity-idp/pull/6288/files#r864759689 [skip changelog]
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
**Why**: So that the build passes, and so that we don't have 500 errors. Context: https://github.com/18F/identity-idp/pull/6288/files#r864759689 [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that the build passes, and so that we don't have 500 errors.
Context: https://github.com/18F/identity-idp/pull/6288/files#r864759689
There's probably a more elegant way to implement this than to repeat the event name string, but I'm most concerned with restoring the passing build.