Test Helpers: Fix usePropertyValue for previously-undefined value#6279
Merged
Test Helpers: Fix usePropertyValue for previously-undefined value#6279
Conversation
**Why**: So that "key in obj" tests don't wrongly report "true" after a test has completed. changelog: Internal, Automated Testing, Improve test helpers to avoid unintentional test failures
nprimak
approved these changes
Apr 29, 2022
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
) * Test Helpers: Fix usePropertyValue for previously-undefined value **Why**: So that "key in obj" tests don't wrongly report "true" after a test has completed. changelog: Internal, Automated Testing, Improve test helpers to avoid unintentional test failures * actually set explicitly-undefined value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that
key in objtests don't wrongly reporttrueafter a test has completed.Observed in #6257 (see example test failure, root cause, impacted code)