Fix 500 error when parsing malformed referer header#6275
Merged
mitchellhenke merged 1 commit intomainfrom Apr 29, 2022
Merged
Conversation
changelog: Bug Fixes, Logging, Fix error during SAML authentication when receiving invalid referer
mitchellhenke
requested review from
aduth,
gsa-manish,
mdiarra3,
orenyk,
stevegsa and
theabrad
mdiarra3
approved these changes
Apr 29, 2022
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
changelog: Bug Fixes, Logging, Fix error during SAML authentication when receiving invalid referer
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
changelog: Bug Fixes, Logging, Fix error during SAML authentication when receiving invalid referer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got a couple 500s in NewRelic in the form of
URI::InvalidURIError: bad URI(is not URI?):on SAML authenticationThis patch uses https://github.com/rails/rails/blob/3520cc77df1b52a6c808083214b583c769e9a4b2/actionpack/lib/action_controller/metal/redirecting.rb#L197-L201 as a reference