Skip to content

Fix changelog_check in GitLab when branch history is longer than clone depth#6272

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/fix-gitlab-git-depth
Apr 28, 2022
Merged

Fix changelog_check in GitLab when branch history is longer than clone depth#6272
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/fix-gitlab-git-depth

Conversation

@mitchellhenke
Copy link
Contributor

No description provided.

changelog: Internal, Continuous Integration, Fix issue with validating the changelog on long branch histories in GitLab
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/fix-gitlab-git-depth branch 2 times, most recently from a30124e to f144f04 Compare April 28, 2022 18:53
@mitchellhenke mitchellhenke marked this pull request as ready for review April 28, 2022 18:53
@mitchellhenke mitchellhenke requested a review from aduth April 28, 2022 18:53
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple fix! 👍

check_changelog:
stage: build
variables:
GIT_DEPTH: 100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if I want 101 commits in my branch? 🙊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where I'm from, we call that a fun opportunity to apply an interactive rebase 😄

(though yes we can absolutely make it longer if we'd prefer)

@mitchellhenke mitchellhenke merged commit 9a96037 into main Apr 28, 2022
@mitchellhenke mitchellhenke deleted the mitchellhenke/fix-gitlab-git-depth branch April 28, 2022 19:42
peggles2 pushed a commit that referenced this pull request May 3, 2022
…6272)

changelog: Internal, Continuous Integration, Fix issue with validating the changelog on long branch histories in GitLab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants