Conversation
…a user reproofs without liveness We use the proofing components on a profile to ensure a user's profile has a liveness check when a liveness check is required. This commit adds a spec to ensure that a user is not marked as having a liveness check present if they reproof without liveness.
Contributor
Author
|
I recommend hiding whitespace changes when reviewing this change
|
mitchellhenke
approved these changes
Apr 27, 2022
…when re-proofing without facial matching
aduth
approved these changes
Apr 27, 2022
Comment on lines
+79
to
+80
| user = User.find(user.id) | ||
| expect(user.active_profile.includes_liveness_check?).to be_falsy |
Contributor
There was a problem hiding this comment.
Is there a reason we have to re-find it here, as opposed to reload-ing it again?
Contributor
Author
There was a problem hiding this comment.
Yeah, the active profile gets memoized
…ness-check-component-removed
stevegsa
approved these changes
Apr 27, 2022
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
…a user reproofs without liveness (#6260) We use the proofing components on a profile to ensure a user's profile has a liveness check when a liveness check is required. This commit adds a spec to ensure that a user is not marked as having a liveness check present if they reproof without liveness. changelog: Internal, Testing, A test was added to cover an edge case when re-proofing without facial matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the proofing components on a profile to ensure a user's profile has a liveness check when a liveness check is required. This commit adds a spec to ensure that a user is not marked as having a liveness check present if they reproof without liveness.