Split up "Account Reset" analytics event (LG-5910)#6238
Merged
zachmargolis merged 5 commits intomainfrom Apr 22, 2022
Merged
Conversation
Sub-events that were split out: - cancel - delete - request - cancel token validation - granted token valdiation - notifications
changelog: Internal, Documentation, Document analytics events
stevegsa
reviewed
Apr 21, 2022
| # An account reset was cancelled | ||
| def account_reset_cancel(user_id:, message_id: nil, request_id: nil, **extra) | ||
| track_event( | ||
| 'Account Reset: cancel', |
Contributor
There was a problem hiding this comment.
don't we still want these as constants?
Contributor
Author
There was a problem hiding this comment.
in all the previous PRs, we haven't been keeping the constants, what would we use them for?
Contributor
There was a problem hiding this comment.
They get used here and in tests, so I could see the case to have constants. I'm comfortable either way though.
Contributor
Author
There was a problem hiding this comment.
Ok, for consistency I'm going to keep this one as is. The bummer is that constants don't get expanded inside YARD Tags so we'd need to find a way to work around that or still have some duplication.
If anybody got a proposal for how we can DRY these and still keep the event documentation working, I'm all ears
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Account Reset" event was wearing a lot of hats... it had an
eventkey and was basically combining a bunch of different separate events. There were some fields in common across these, but I think it's easier to reason about if we separate them.Bonus: migrated
ACCOUNT_RESET_VISITwhile I was here