Skip to content

LG-6199: Show current IdV app step as page title#6232

Merged
aduth merged 2 commits intomainfrom
aduth-lg-6199-step-title
Apr 21, 2022
Merged

LG-6199: Show current IdV app step as page title#6232
aduth merged 2 commits intomainfrom
aduth-lg-6199-step-title

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Apr 21, 2022

Why:

  • As a user, I expect that each page is uniquely titled, so that I can understand its purpose.
  • Feature parity with existing step implementation.

Testing Instructions:

  1. Set idv_api_enabled: "true" in local config/application.yml
  2. Go to: http://localhost:3000/verify/v2
  3. Observe browser tab title is "Save your personal key - Login.gov"

Implementation Notes:

Based on current implementation:

<%= content_tag(
'title',
content_for?(:title) ? raw("#{yield(:title)} - #{APP_NAME}") : APP_NAME,
) %>

<% title t('titles.idv.personal_key') %>

Screenshot:

image

**Why**:

- As a user, I expect that each page is uniquely titled, so that I can understand its purpose.
- Feature parity with existing step implementation.

changelog: Upcoming Features, Identity Verification, Add personal key step screen
@aduth aduth requested review from nprimak, peggles2 and solipet April 21, 2022 13:41
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit 0d74232 into main Apr 21, 2022
@aduth aduth deleted the aduth-lg-6199-step-title branch April 21, 2022 16:47
@jmdembe jmdembe mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants