Skip to content

Pin idp/ci to the current sha#6228

Merged
akrito merged 2 commits intomainfrom
akrito/digest
Apr 20, 2022
Merged

Pin idp/ci to the current sha#6228
akrito merged 2 commits intomainfrom
akrito/digest

Conversation

@akrito
Copy link
Contributor

@akrito akrito commented Apr 20, 2022

[skip changelog]

@akrito akrito requested a review from mitchellhenke April 20, 2022 15:52
.gitlab-ci.yml Outdated

default:
image: "${ECR_REGISTRY}/idp/ci:latest"
image: "${ECR_REGISTRY}/idp/ci@sha256:8650f43d0e6d44729bff92657b59e511c874103ae6207b3c0781df042df6932f"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do this via env var as well so we don't need a source code change every time? esp since the registry is already an env var?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Done.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akrito akrito merged commit d92c7af into main Apr 20, 2022
@akrito akrito deleted the akrito/digest branch April 20, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants