LG-6158: Use FullScreen component for modal component#6220
Merged
Conversation
nprimak
approved these changes
Apr 19, 2022
Contributor
nprimak
left a comment
There was a problem hiding this comment.
Works as expected! Definitely some things in here I'd like to familiarize myself with more.
Stylistic rules conflict with Prettier
**Why**: To share
**Why**: To share
**Why**: To allow a "labelledby" additional feature
**Why**: To reuse common accessibility behaviors, including inert background content, focus trap, autofocus, deactivation triggers (e.g. escape button). changelog: Upcoming Features, Identity Verification, Add personal key step screen
4238cb7 to
9a171f9
Compare
Contributor
Author
Since #6219 was merged, I rebased the branch and wired up the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To reuse common accessibility behaviors, including inert background content, focus trap, autofocus, deactivation triggers (e.g. escape button).
Testing Instructions:
idv_api_enabled: "true"in localconfig/application.ymlExtra credit: Test to confirm there are no regressions to document capture Acuant SDK full-screen dialog experience.
Follow-up items:
FullScreen
onRequestClosebehaviors should be wired up to return the user to the previous step on Escape keypress or on clicking the backdrop. This depends on proposed changes at #6219.