Skip to content

LG-6158: Use FullScreen component for modal component#6220

Merged
aduth merged 11 commits intomainfrom
aduth-full-screen-modal
Apr 20, 2022
Merged

LG-6158: Use FullScreen component for modal component#6220
aduth merged 11 commits intomainfrom
aduth-full-screen-modal

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Apr 19, 2022

Why: To reuse common accessibility behaviors, including inert background content, focus trap, autofocus, deactivation triggers (e.g. escape button).

Testing Instructions:

  1. Set idv_api_enabled: "true" in local config/application.yml
  2. Go to: http://localhost:3000/verify/v2/personal_key_confirm
  3. Observe that input field has focus
  4. Tab through content up to and including the end of content
  5. Observe that focus loops back to beginning of content after end
  6. Activate screen reader web rotor
  7. Observe that the only content listed in web rotor is modal content

Extra credit: Test to confirm there are no regressions to document capture Acuant SDK full-screen dialog experience.

Follow-up items:

FullScreen onRequestClose behaviors should be wired up to return the user to the previous step on Escape keypress or on clicking the backdrop. This depends on proposed changes at #6219.

Copy link
Contributor

@nprimak nprimak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Definitely some things in here I'd like to familiarize myself with more.

aduth added 9 commits April 20, 2022 08:36
Stylistic rules conflict with Prettier
**Why**: To allow a "labelledby" additional feature
**Why**: To reuse common accessibility behaviors, including inert background content, focus trap, autofocus, deactivation triggers (e.g. escape button).

changelog: Upcoming Features, Identity Verification, Add personal key step screen
@aduth aduth force-pushed the aduth-full-screen-modal branch from 4238cb7 to 9a171f9 Compare April 20, 2022 12:40
@aduth
Copy link
Contributor Author

aduth commented Apr 20, 2022

Follow-up items:

FullScreen onRequestClose behaviors should be wired up to return the user to the previous step on Escape keypress or on clicking the backdrop. This depends on proposed changes at #6219.

Since #6219 was merged, I rebased the branch and wired up the FullScreen onRequestClose to trigger toPreviousStep in 9a171f9 (spec in fde87d1). I don't think I'll implement it here, but maybe it could also be good to have a "click outside to close" behavior, closing the dialog if the user clicks on the modal backdrop.

@aduth aduth merged commit 87dfefd into main Apr 20, 2022
@aduth aduth deleted the aduth-full-screen-modal branch April 20, 2022 15:08
@jmdembe jmdembe mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants