LG-6159: Add icons for personal key buttons#6212
Conversation
| assets = AssetSources.get_assets(*names) | ||
| if assets.present? | ||
| asset_map = assets.index_with { |path| asset_path(path) } | ||
| asset_map = assets.index_with { |path| asset_path(path, host: asset_host(path)) } |
There was a problem hiding this comment.
For extra context on why we have to do this, see #5895 and related discussions / resources.
aduth
changed the title
|
Testing this in my personal environment (with asset host), I'm not seeing the icons 🤔 Will have to investigate what's going on... |
This turned out to be a separate issue, addressed in #6214. |
For consistency with ButtonComponent ViewComponent
changelog: Upcoming Features, Identity Verification, Add personal key step screen
Not necessary, since the condition considers the config value, not env
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
force-pushed
the
aduth-button-icon-prop
branch
from
663905f to
dd0f72b
Compare
nprimak
left a comment
nprimak
left a comment
There was a problem hiding this comment.
Following testing instructions icons appear as expected 👍
| | 'zoom_in' | ||
| | 'zoom_out' | ||
| | 'zoom_out_map'; | ||
|
|
There was a problem hiding this comment.
Might be nice to have this list live in another file, just for the sake of readability.
There was a problem hiding this comment.
Hm, that's a good thought. I guess the question is... where to put it?
One consideration is that I'm hoping to remove the "Custom Icon" implementation mixed in here (createIconComponent), since the one icon being used is available through this new icon set (photo_camera), which will hopefully make the file a bit smaller overall.
I think I'll plan to merge this as-is, but follow-up with that work, and if we decide there's a better place for the icon list type, I can plan to include it there.
3 participants
Why: For feature parity with the existing personal key screen experience.
Testing Instructions:
idv_api_enabled: "true"in localconfig/application.ymlScreenshots: