Upload artifact and sync static assets in GitLab CI#6207
Merged
mitchellhenke merged 5 commits intomainfrom Apr 28, 2022
Merged
Conversation
zachmargolis
approved these changes
Apr 19, 2022
Comment on lines
212
to
+216
| - make build_artifact ARTIFACT_DESTINATION_FILE='./tmp/idp.tar.gz' | ||
| - bundle exec ./scripts/artifact-upload './tmp/idp.tar.gz' |
Contributor
There was a problem hiding this comment.
could we move ARTIFACT_DESTINATION_FILE to the variables block above and reuse it on both these lines?
Suggested change
| - make build_artifact ARTIFACT_DESTINATION_FILE='./tmp/idp.tar.gz' | |
| - bundle exec ./scripts/artifact-upload './tmp/idp.tar.gz' | |
| - make build_artifact | |
| - bundle exec ./scripts/artifact-upload $ARTIFACT_DESTINATION_FILE |
Closed
mitchellhenke
force-pushed
the
mitchellhenke/partially-deploy-via-gitlab
branch
2 times, most recently
from
93bb921 to
89b64d7
Compare
added 3 commits
April 28, 2022 14:59
changelog: Internal, Continuous Deployment, Enable uploading application artifacts and static assets from GitLab CI
mitchellhenke
force-pushed
the
mitchellhenke/partially-deploy-via-gitlab
branch
from
89b64d7 to
c0a349b
Compare
mitchellhenke
force-pushed
the
mitchellhenke/partially-deploy-via-gitlab
branch
from
fc8d334 to
e9b7267
Compare
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
* Upload artifact and sync static assets in GitLab CI changelog: Internal, Continuous Deployment, Enable uploading application artifacts and static assets from GitLab CI * add execute permissions to script * fix sources for running pipeline * add ruby cache to coverage step * return early if current branch is not configured
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
* Upload artifact and sync static assets in GitLab CI changelog: Internal, Continuous Deployment, Enable uploading application artifacts and static assets from GitLab CI * add execute permissions to script * fix sources for running pipeline * add ruby cache to coverage step * return early if current branch is not configured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/18F/identity-devops/pull/4533