Skip to content

LG-6066: Initialize personal key value and render badge content#6206

Merged
aduth merged 4 commits intomainfrom
aduth-personal-key-content
Apr 15, 2022
Merged

LG-6066: Initialize personal key value and render badge content#6206
aduth merged 4 commits intomainfrom
aduth-personal-key-content

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Apr 14, 2022

Why: As an incremental step toward getting actual personal key initialized into the page, for feature parity with existing step.

Markup reference: https://github.com/18F/identity-idp/blob/main/app/views/partials/personal_key/_key.html.erb

Testing Instructions:

  1. Set idv_api_enabled: "true" in local config/application.yml
  2. Go to: http://localhost:3000/verify/v2/personal_key
  3. See personal key and "Generated on [Today's Date]"

Screenshots:

Before After
localhost_3000_verify_v2_personal_key (1) localhost_3000_verify_v2_personal_key

**Why**: As an incremental step toward getting actual personal key initialized into the page, for feature parity with existing step.

changelog: Upcoming Features, Identity Verification, Add personal key step screen
@aduth aduth requested review from nprimak, peggles2 and solipet April 14, 2022 14:46
aduth added 2 commits April 14, 2022 10:48
We probably won't need it, since we'll be persisting values client-side
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should be camelCase for JavaScript app, but avoid camelCase symbols in Ruby

See: #6206 (comment)
Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
@aduth aduth merged commit f671553 into main Apr 15, 2022
@aduth aduth deleted the aduth-personal-key-content branch April 15, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants