Merged
Conversation
…n account creation, LG-5988
…ute-to-interstatial
…ute-to-interstatial
mdiarra3
changed the title
mdiarra3
force-pushed
the
LG-6086-route-to-interstatial
branch
from
3e4c749 to
95842b3
Compare
zachmargolis
approved these changes
Apr 20, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, one last comment about renaming maybe
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
* Add setup router * delete authenticator service * LG-5988: work on routing for multiple selections * LG-5988: remove uneeded helper * changelog: Upcoming Feature, Allow Users to add more than one MFA method on account creation, LG-5988 * LG-5988: spec * LG-5988: address comments * rubocop * Refactor how were doing user updating otp method * rubocop * LG-5988: change method name * redirect fix * update routing * LG-5988: use index * use dig to reduce errors * rubocop * check phone * Ensure next url * LG-6086: check to see if next available * LG-5988: rubocop * LG-6086: add translations for language * LG-5988: use shift for now * LG-6086: route to interstatial * LG-6086: rubocop * move params call to own method * LG-6086: have show visible * totp fix * Normalize yaml * LG-6086: routes * changelog: add interstitial page between page * LG-6086: use account url * rubocop issue * multipel mfa signup fix * multiple mfa signup featuere test fix * ensure you add a final path * Use url * LG-6086: refactor to support going back * LG-6086: interstitial fixup tests * check backup choice * fix render issue * make sure to add params * rubocop * make sure to click properly * feature test fix * LG-6086 clear session properly * update show * fix html * otp verification * mfa confirmations controller logic fix * LG-6086: remove ordanilize * update show presenter * LG-6086: update presenter * LG-6086: fix missing keys * normalize yaml * next setup choice * LG-6086: update to fix tests * fix locales * rename name * spec * mfa cta spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an interstitial page to this logic.
Might rework some of this logic to be a little more idempotent.