In-Person-Proofing "Beta" Tag (LG-6073)#6192
Conversation
app/assets/stylesheets/components/_troubleshooting-options.scss
Outdated
Show resolved
Hide resolved
changelog: Upcoming Features, In-Person Proofing, Add "new features" badge for links
| </p> | ||
| <% end %> | ||
|
|
||
| <%= render TroubleshootingOptionsComponent.new(new_features: true) do |c| %> |
There was a problem hiding this comment.
since this is repeated 3 times should it be broken out into its own file?
There was a problem hiding this comment.
like a partial for just the IPP-specific options? sure will give it a shot
stevegsa
left a comment
There was a problem hiding this comment.
Excellent. My only concern is that user hasn't given their best effort before presenting the in-person option. ie image blurry. However, it seems there would be no reliable way to determine that.
app/assets/stylesheets/components/_troubleshooting-options.scss
Outdated
Show resolved
Hide resolved
app/views/idv/session_errors/_in_person_proofing_options.html.erb
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
Can remove margin-top-3 from the tag, since the top margin on the section (2 rem) is enough space.
And the caveat: users won't actually see the option to proof in-person from the /verify/session/errors/failure i.e. "We could not find records matching your personal information" screen after the SSN/personal details verification, right? I think you mentioned there was a reason to maintain the different versions.
For translations: I hadn't included those yet because I planned to get everything translated after usability testing and a final content review from @Danielle-Lee, since things are still in flux (for example, the heading changed yesterday). OK to ticket separately, or would you prefer to keep up with translations now? If so, let's loop in Danielle who may want to handle the translation request.
Otherwise LGTM thank you!
removed in 5aafbd9
I'm not 100% certain, but I can remove the links from that page if we want?
I ran with what was in the Figma, so long as we remember to update later, copy changes are pretty easy to incorporate later |
Adds a "new feature" tag that separates this new option, to both client (for doc auth errors) and server (for other errors)
I've deployed this to my personal env to click around on (https://idp.zmargolis.identitysandbox.gov/)
/verify/session/errors/failure/verify/session/errors/throttled/verify/session/errors/exception/verify/session/errors/warning(removed IPP link, since the error message indicates Resolution failed, but that's required to pass for this iteration of IPP)